(fix)[deleteJob] It will not dispatch task when backend has been drop… #59569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ped or not alive on delete from command.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
yiguolei
reviewed
Jan 6, 2026
| st = status; | ||
| public void addMark(K key, V value) { | ||
| synchronized (lock) { | ||
| marks.put(key, value); |
Contributor
There was a problem hiding this comment.
这里如果downLatch ！= null，需要报错，我们不能够支持await 之后，还变更mark的数量
Contributor
Author
There was a problem hiding this comment.
OK，这里可以增加一个判断的，之所以让这个行为存在主要是为了兼容之前的写入，我们可以让使用者在事先就知道目标的count是多少，然后调用有count的构造函数在构建MarkedCountDownLatch时就初始化downLatch，如果可以不兼容这种情况那么是需要在这里限制这种行为的。
yiguolei
reviewed
Jan 6, 2026
| public synchronized void addMark(K key, V value) { | ||
| marks.put(key, value); | ||
| public long getCount() { | ||
| synchronized (lock) { |
Contributor
There was a problem hiding this comment.
这个lock，跟直接在函数上加synchronized 修饰有什么区别？
Contributor
Author
There was a problem hiding this comment.
这里主要是考虑到了部分函数比如说wait不是锁整个method只是锁住代码块，为了整个类的风格统一所以在函数内使用代码块的锁
yiguolei
reviewed
Jan 6, 2026
| public MarkedCountDownLatch(int count) { | ||
| super(count); | ||
| this.markCount = count; | ||
| this.downLatch = new CountDownLatch(count); |
Contributor
There was a problem hiding this comment.
如果这个构造函数去不掉，就说明有的时候，我们的这个count 可能不等于marks的数量，可能是有问题的
Contributor
Author
There was a problem hiding this comment.
这个构造函数和上面一样是为了减少改动量，兼容之前的一些使用方式
ghkang98
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
yiguolei
reviewed
Jan 12, 2026
| if (marks.remove(key, value)) { | ||
| super.countDown(); | ||
| return true; | ||
| public void countDown() { |
Contributor
There was a problem hiding this comment.
我们需要这种api 存在吗？ 此时marks 里的东西没有清空，后续是不是对不上了？
Contributor
There was a problem hiding this comment.
是不是只需要保留marked count down 就可以了？
yiguolei
reviewed
Jan 12, 2026
|
|
||
| public synchronized void addMark(K key, V value) { | ||
| marks.put(key, value); | ||
| public long getCount() { |
ghkang98
force-pushed
the
fix-delete-job
branch
from
2c8ca0c to
e101417
Compare
yiguolei
previously approved these changes
Jan 13, 2026
Contributor
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
ghkang98
force-pushed
the
fix-delete-job
branch
from
e101417 to
221111d
Compare
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31879 ms |
TPC-DS: Total hot run time: 173137 ms |
ClickBench: Total hot run time: 26.74 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31228 ms |
TPC-DS: Total hot run time: 173479 ms |
ClickBench: Total hot run time: 26.93 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31281 ms |
TPC-DS: Total hot run time: 174143 ms |
ClickBench: Total hot run time: 26.87 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 30755 ms |
TPC-DS: Total hot run time: 172508 ms |
ClickBench: Total hot run time: 27.11 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ped or not alive on delete from command.
When a node is abnormal or dropped, the delete job function does not filter the replicas for these nodes, resulting in failure during task dispatch and causing the task to not execute properly during the Delete operation. On the other hand, after a task execution fails, it keeps retrying; however, it does not adequately consider that in certain scenarios a retry cannot resolve the issue and can only rely on the overall timeout of the outer task to terminate, which can lead to the task being stuck for a long time.